Ticket #479: 1184.diff

branches/1.0/php/xlogin.php

@@ -86 +86 @@
 
    // Get the expected form variables from the POST array
-   if (isset($_POST["language"])) {
+   if (isset($_POST["language"])   && strlen($_POST["language"]) == 2 ) {
       $display_language = trim($_POST["language"]);
    } else {
       $display_language = $default_display_language;
    }
-   if (isset($_POST["charset"])) {
+   if (isset($_POST["charset"]) && preg_match("/^[\x20-\x7e]{1,40}$/", $_POST["charset"])) {
       $html_charset = trim($_POST["charset"]);
    } else {

branches/1.0/php/login.php

@@ -81 +81 @@
    if (isset($_GET["super"])) {
       $super = trim($_GET["super"]);
+      if($super != "register" && $super != "unregister") {
+        $logger->err("invalid super parameter");
+        $super = "";
+      }
    } else {
       $super = "";
@@ -86 +90 @@
 
    // Determine the initial language preference,
-   // either from default or from manually selected link 
-   if (isset($_GET["lang"])) {
+   // either from default or from manually selected link
+   if (isset($_GET["lang"]) && strlen($_GET["lang"]) == 2 ) {
       $display_language = trim($_GET["lang"]);
       $display_language_is_default = false;
-   } elseif (isset($_GET["prevlang"])) {
+   } elseif (isset($_GET["prevlang"]) && strlen($_GET["prevlang"]) == 2) {
       $display_language = trim($_GET["prevlang"]);
       $display_language_is_default = true;
@@ -111 +115 @@
 
    // Determine the user's character set preference
-   if (isset($_GET["charset"])) {
+   // Charset must be printable ascii, 1-40 characters.  /^[\x20-\x7e]{1,40}$/
+   if (isset($_GET["charset"]) && preg_match("/^[\x20-\x7e]{1,40}$/", $_GET["charset"])) {
        $html_charset = trim($_GET["charset"]);
    } else {

branches/1.0/php/internal-init.php

@@ -87 +87 @@
 
     // Determine the user's language preference
-    if (isset($_GET["lang"])) {
+    if (isset($_GET["lang"]) && strlen($_GET["lang"]) == 2 ) {
        $display_language = trim($_GET["lang"]);
     } else {
@@ -98 +98 @@
 
     // Determine the user's character set preference
-    if (isset($_GET["charset"])) {
+    if (isset($_GET["charset"]) && preg_match("/^[\x20-\x7e]{1,40}$/", $_GET["charset"])) {
         $html_charset = trim($_GET["charset"]);
     } else {