Ticket #235 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

[PATCH] Stats branch Amavisd-maia is mistaking quaran_level for kill_level

Reported by: cgardiner Owned by: rjl
Priority: normal Milestone:
Component: amavisd-maia Version:
Severity: normal Keywords:
Cc:

Description

After running the stats branch for a while, I'm noticing an interesting little quirk. It appears that the spam_quaran_level and the spam_kill_level are reversed in the amavisd-maia script in the stats branch.

It does not seem to have effected mail delivery in anyway which makes we wonder if the kill level is implimented fully or even if I really understand what it is supposed to do functionally. (If someone could explain that I would greatly appreciate it)

What I am noticing however is that any new users created in the database from amavisd are getting created with the spam_quaran_level and spam_kill_level values reversed.

It appears that when the Select statment was modified to add the new Database field, the array values were transposed.

Here is a small patch I put together to fix it. I do not however have any idea what effect it will have elsewhere though I can say from experience that mails still seem to be flowing and getting quaranteened correctly. (again I'm a little baffled but if someone could explain to me I would greatly appreciate it.)

Attachments

amavisd-maia.patch (1.9 kB) - added by cgardiner 5 years ago.

Change History

Changed 5 years ago by cgardiner

Changed 5 years ago by jleaver

  • status changed from new to closed
  • resolution set to fixed

I've updated svn to include this patch. Kill level is designed as a cut-off level for spam scoring. When a suspected spam scored above spam_kill_level, spam is not quarantined for that recipient, it is, instead, silently discarded.

Changed 4 years ago by rjl

  • summary changed from Stats branch Amavisd-maia is mistaking quaran_level for kill_level to [PATCH] Stats branch Amavisd-maia is mistaking quaran_level for kill_level
Note: See TracTickets for help on using tickets.