cannot use scalar value as array in cache.php

[dmorton]

Gary Casterline reports:

I'm seeing a problem reviewing virus/malware.
No problem with Spam or Ham, but when a user
selects the Delete/Rescue under the virus/malware
area ("https://[...]/mail/list-cache.php?cache_type=virus")
an error comes up:

2006-05-11 13:04:43 (PDT) 2 Warning Cannot use a scalar value
      as an array /[...]/mail/cache.php 434 
2006-05-11 13:04:43 (PDT) 2 Warning Invalid argument supplied
      for foreach() /[...]/mail/cache.php 434

[dmorton]

Fixed in [1047]. The error reporting in [1045] and [1046] helped trace it down to an error with the generated SQL query; It seems mysql 5 doesn't like the mixed join or something. Running the query by hand yielded:

Unknown column 'maia_mail.id' in 'on clause'

I changed the query to use all LEFT JOINS.

Thanks to Gary Casterline for reporting and testing this out for me.