Ticket #326 (closed defect: fixed)

Opened 8 years ago

Last modified 7 years ago

chart code incompatibility with new PEAR module

Reported by: dmorton Owned by: dmorton
Priority: normal Milestone: 1.0.2
Component: PHP scripts Version: 1.0.1
Severity: normal Keywords: graphs legend
Cc:

Description

The PEAR module changed API on us somehow, and the Legend text does not appear in newer versions. Works at least up to Image_Graph 0.7.1 alpha, and is reported broken in 0.7.2

Attachments

Pie.php.patch (0.5 kB) - added by rjl 7 years ago.
Patch for Graph/Plot/Pie.php (context diff)

Change History

Changed 8 years ago by rjl

It's been confirmed that downgrading to Image_Graph 0.7.1 solves the problem, which would seem to confirm that something significant changed in 0.7.2. That said, 0.7.2 should probably become the minimum version requirement going forward, since it offers a number of new features we'll almost certainly want to take advantage of, including built-in support for grouping items with values below a specified threshold into a catch-all "others" group. It's just a matter of adapting the current chart code to work with 0.7.2 and increasing the minimum version requirement in configtest.php.

Changed 8 years ago by rjl

  • patch changed from 0 to 1

An update from Michael Enkelis, who points out that the behaviour in Image_Graph 0.7.2 is a known bug in the Pie.php file, and has been fixed in the CVS version. Evidently using this CVS version of Pie.php as a drop-in replacement for the version shipped with 0.7.2 solves the problem.

Changed 8 years ago by dmorton

We could add a check to configtest.php to warn about this version...

Changed 8 years ago by rjl

Have configtest.php direct users to the one-line patch attached to this ticket, which fixes the problem with 0.7.2. For the other reasons I mentioned earlier, I still think 0.7.2 needs to be considered the new minimum--the catch-all grouping of items with values below a certain threshold is one of the features we were going to have to implement ourselves, and it's now standard in 0.7.2. Once 0.7.3 becomes available we can avoid this problem altogether by upping the minimum version requirement to 0.7.3.

Changed 8 years ago by dmorton

  • status changed from new to closed
  • resolution set to fixed

[1127] added warning to configtest.php

Changed 8 years ago by anonymous

  • status changed from closed to reopened
  • resolution fixed deleted

How do you apply this patch?

-Thanks

Changed 7 years ago by anonymous

Okay, so what is the attachment (file name?) and where does it go?

Changed 7 years ago by anonymous

  • patch changed from 1 to 0

The attachment "03/21/07" is the complete Image/Graph/Plot/Pie.php

modified.

Changed 7 years ago by dmorton

  • patch changed from 0 to 1

Changed 7 years ago by rjl

Patch for Graph/Plot/Pie.php (context diff)

Changed 7 years ago by dmorton

  • status changed from reopened to closed
  • resolution set to fixed

Ticket should have been closed, probably lost in the server crash.

Note: See TracTickets for help on using tickets.