maiadbtool.pl doesn't observe the auto-issue passwords flag

[rjl]

When new users are added with maiadbtool.pl and internal authentication is used, temporary passwords are generated and a welcome email is issued to these new users, even if the auto-issue passwords flag is not set.

This is because of the unfortunate naming of a variable called internal_auth, which is a column in the maia_config table set by the "Auto-issue passwords to new accounts" feature on the System Configuration page. The maiadbtool.pl script should be checking maia_config.internal_auth, but instead it is mistakenly checking $auth_method, which is set in maia.conf and means something altogether different.

In the longer term, maia_config.internal_auth really needs to be renamed to something more accurate, e.g. maia_config.issue_passwords.

[dmorton]

Due to the new authentication methods in the 1.1 branch, the config value will be pulled from the database on a per-domain fashion anyway.

[rjl]

Fixed in [1234].